fix: missing authority host param and resource management endpoint when init the client #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
locmai
changed the title
tomkerkhove
reviewed
May 28, 2021
src/Promitor.Integrations.Azure/Authentication/AzureAuthenticationFactory.cs
Outdated
Show resolved
Hide resolved
src/Promitor.Agents.ResourceDiscovery/Graph/AzureResourceGraph.cs
Outdated
Show resolved
Hide resolved
|
It looks good, thank you for the PR! I'll wait with merging until you've been able to scrape it but happy to help where I can! |
tomkerkhove
approved these changes
May 28, 2021
I am able to scrape the metrics and export them to my Prometheus after adding the azureMetadata.cloud in the configmap, the PR for the chart got merged too. |
|
Awesome, thanks a ton @locmai! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Relates to #1646
Description
This PR fixes 2 parts: